github-actions[bot] commented on code in PR #28964:
URL: https://github.com/apache/doris/pull/28964#discussion_r1435981477
##########
be/test/olap/storage_engine_test.cpp:
##########
@@ -21,32 +21,46 @@
#include <gmock/gmock-matchers.h>
#include <gtest/gtest-message.h>
#include <gtest/gtest-test-part.h>
+#include <gtest/gtest.h>
#include <filesystem>
#include "common/status.h"
#include "gtest/gtest_pred_impl.h"
-#include "testutil/test_util.h"
-
-using ::testing::_;
-using ::testing::Return;
-using ::testing::SetArgPointee;
-using std::string;
+#include "io/fs/local_file_system.h"
+#include "olap/data_dir.h"
+#include "olap/tablet_manager.h"
+#include "util/threadpool.h"
namespace doris {
using namespace config;
class StorageEngineTest : public testing::Test {
public:
virtual void SetUp() {
+ _engine_data_path = "./be/test/olap/test_data/converter_test_data/tmp";
+ EXPECT_TRUE(
+
io::global_local_filesystem()->delete_and_create_directory(_engine_data_path).ok());
+ EXPECT_TRUE(
+
io::global_local_filesystem()->create_directory(_engine_data_path +
"/meta").ok());
+ _data_dir.reset(new DataDir(_engine_data_path, 100000000));
+ static_cast<void>(_data_dir->init());
+
EngineOptions options;
+ options.backend_uid = UniqueId::gen_uid();
_storage_engine.reset(new StorageEngine(options));
+ ExecEnv::GetInstance()->set_storage_engine(_storage_engine.get());
}
- virtual void TearDown() {}
+ virtual void TearDown() {
Review Comment:
warning: prefer using 'override' or (rarely) 'final' instead of 'virtual'
[modernize-use-override]
```suggestion
void TearDown() override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
