yiguolei commented on code in PR #28103:
URL: https://github.com/apache/doris/pull/28103#discussion_r1435939520
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -392,35 +396,57 @@ Status SegmentIterator::_get_row_ranges_by_keys() {
DorisMetrics::instance()->segment_row_total->increment(num_rows());
// fast path for empty segment or empty key ranges
- if (_row_bitmap.isEmpty() || _opts.key_ranges.empty()) {
- return Status::OK();
- }
-
- // Read & seek key columns is a waste of time when no key column in _schema
- if (std::none_of(_schema->columns().begin(), _schema->columns().end(),
[&](const Field* col) {
- return col &&
_opts.tablet_schema->column_by_uid(col->unique_id()).is_key();
- })) {
+ if (_row_bitmap.isEmpty() || (!_opts.split_key_range.valid &&
_opts.key_ranges.empty())) {
return Status::OK();
}
RowRanges result_ranges;
- for (auto& key_range : _opts.key_ranges) {
+ if (_opts.split_key_range.valid) {
rowid_t lower_rowid = 0;
rowid_t upper_rowid = num_rows();
- RETURN_IF_ERROR(_prepare_seek(key_range));
- if (key_range.upper_key != nullptr) {
- // If client want to read upper_bound, the include_upper is true.
So we
- // should get the first ordinal at which key is larger than
upper_bound.
- // So we call _lookup_ordinal with include_upper's negate
- RETURN_IF_ERROR(_lookup_ordinal(*key_range.upper_key,
!key_range.include_upper,
- num_rows(), &upper_rowid));
+
+ RETURN_IF_ERROR(_prepare_seek(_opts.split_key_range));
+
+ if (!_opts.split_key_range.upper_key.key.empty()) {
+ RETURN_IF_ERROR(_lookup_ordinal_from_sk_index<false>(
Review Comment:
split key range ，如果传递的是string，那么 200 就没了，消息就丧失了。 look up的时候就不能准确比较了。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
