xiaokang commented on code in PR #28704:
URL: https://github.com/apache/doris/pull/28704#discussion_r1434613132
##########
docs/zh-CN/docs/data-table/index/inverted-index.md:
##########
@@ -90,6 +90,9 @@ Doris倒排索引的功能简要介绍如下：
- ignore_above：控制字符串是否建索引。
- 长度超过 ignore_above 设置的字符串不会被索引。对于字符串数组，ignore_above 将分别应用于每个数组元素，长度超过
ignore_above 的字符串元素将不被索引。
- 默认为 256 字节
+ - lowercase: 是否将分词进行小写转换，从而在匹配的时候实现忽略大小写
Review Comment:
keep consistent with code 'lower_case'
##########
be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:
##########
@@ -192,6 +192,12 @@ class InvertedIndexColumnWriterImpl : public
InvertedIndexColumnWriter {
// ANALYSER_NOT_SET, ANALYSER_NONE use default SimpleAnalyzer
_analyzer =
std::make_unique<lucene::analysis::SimpleAnalyzer<char>>();
}
+ auto lowercase =
get_parser_lowercase_from_properties(_index_meta->properties());
+ if (lowercase == "true") {
+ _analyzer->set_lowercase(true);
+ } else if (lowercase == "false") {
+ _analyzer->set_lowercase(false);
+ }
Review Comment:
what about else lowercase == "" if use have not set this property?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
