yiguolei commented on code in PR #28698:
URL: https://github.com/apache/doris/pull/28698#discussion_r1432530620
##########
be/src/pipeline/exec/exchange_sink_operator.cpp:
##########
@@ -456,21 +449,16 @@ void ExchangeSinkLocalState::register_channels(
}
Status ExchangeSinkLocalState::get_next_available_buffer(
- vectorized::BroadcastPBlockHolder** holder) {
+ std::shared_ptr<vectorized::BroadcastPBlockHolder>* holder) {
Review Comment:
We'd better keep the pattern. If the parameter is the output parameter, then
use pointer not reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
