github-actions[bot] commented on code in PR #27943:
URL: https://github.com/apache/doris/pull/27943#discussion_r1432266287
##########
be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:
##########
@@ -235,10 +232,10 @@ void
NestedLoopJoinProbeLocalState::_resize_fill_tuple_is_null_column(size_t new
}
template <bool BuildSide, bool IsSemi>
-void
NestedLoopJoinProbeLocalState::_finalize_current_phase(vectorized::MutableBlock&
mutable_block,
+void NestedLoopJoinProbeLocalState::_finalize_current_phase(vectorized::Block&
block,
Review Comment:
warning: function '_finalize_current_phase' has cognitive complexity of 74
(threshold 50) [readability-function-cognitive-complexity]
```cpp
void
NestedLoopJoinProbeLocalState::_finalize_current_phase(vectorized::Block& block,
^
```
<details>
<summary>Additional context</summary>
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:240:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if constexpr (BuildSide) {
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:244:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
for (; i < build_block_sz && column_size < batch_size; i++) {
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:244:** +1
```cpp
for (; i < build_block_sz && column_size < batch_size; i++) {
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:255:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
for (size_t j = 0; j < num_rows; j++) {
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:256:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
if constexpr (IsSemi) {
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:257:** +5,
including nesting penalty of 4, nesting level increased to 5
```cpp
if (cur_visited_flags[j]) {
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:260:** +1,
nesting level increased to 4
```cpp
} else {
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:261:** +5,
including nesting penalty of 4, nesting level increased to 5
```cpp
if (!cur_visited_flags[j]) {
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:268:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
for (size_t j = 0; j < p._num_probe_side_columns; ++j) {
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:275:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
for (size_t j = 0; j < p._num_build_side_columns; ++j) {
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:277:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
if (!src_column.column->is_nullable() &&
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:277:** +1
```cpp
if (!src_column.column->is_nullable() &&
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:290:** +1,
nesting level increased to 4
```cpp
} else {
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:299:** +1,
nesting level increased to 1
```cpp
} else {
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:300:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (!p._is_mark_join) {
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:303:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
for (int j = _left_block_start_pos;
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:305:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
if (_cur_probe_row_visited_flags[j] == IsSemi) {
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:307:** +5,
including nesting penalty of 4, nesting level increased to 5
```cpp
for (size_t i = 0; i < p._num_probe_side_columns; ++i) {
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:310:** +6,
including nesting penalty of 5, nesting level increased to 6
```cpp
if (!src_column.column->is_nullable() &&
dst_columns[i]->is_nullable()) {
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:310:** +1
```cpp
if (!src_column.column->is_nullable() &&
dst_columns[i]->is_nullable()) {
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:319:** +1,
nesting level increased to 6
```cpp
} else {
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:325:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if (new_size > column_size) {
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:326:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
for (size_t i = 0; i < p._num_build_side_columns; ++i) {
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:332:** +1,
nesting level increased to 2
```cpp
} else {
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:336:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
for (int j = _left_block_start_pos;
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:340:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
for (size_t i = 0; i < p._num_probe_side_columns; ++i) {
^
```
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:347:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
for (size_t i = 0; i < p._num_build_side_columns; ++i) {
^
```
</details>
##########
be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:
##########
@@ -235,10 +232,10 @@
}
template <bool BuildSide, bool IsSemi>
-void
NestedLoopJoinProbeLocalState::_finalize_current_phase(vectorized::MutableBlock&
mutable_block,
+void NestedLoopJoinProbeLocalState::_finalize_current_phase(vectorized::Block&
block,
Review Comment:
warning: function '_finalize_current_phase' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
void
NestedLoopJoinProbeLocalState::_finalize_current_phase(vectorized::Block& block,
^
```
<details>
<summary>Additional context</summary>
**be/src/pipeline/exec/nested_loop_join_probe_operator.cpp:234:** 120 lines
including whitespace and comments (threshold 80)
```cpp
void
NestedLoopJoinProbeLocalState::_finalize_current_phase(vectorized::Block& block,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
