github-actions[bot] commented on code in PR #27726:
URL: https://github.com/apache/doris/pull/27726#discussion_r1428745164
##########
be/src/olap/wal_manager.cpp:
##########
@@ -75,11 +99,49 @@ Status WalManager::init() {
}
RETURN_IF_ERROR(scan_wals(wal_dir));
}
+ RETURN_IF_ERROR(init_wal_limit());
return Thread::create(
"WalMgr", "replay_wal", [this]() {
static_cast<void>(this->replay()); },
&_replay_thread);
}
+Status WalManager::init_wal_limit() {
Review Comment:
warning: method 'init_wal_limit' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/wal_manager.h:77:
```diff
- Status init_wal_limit();
+ static Status init_wal_limit();
```
##########
be/src/vec/sink/group_commit_block_sink.cpp:
##########
@@ -218,5 +244,16 @@ Status GroupCommitBlockSink::_add_blocks() {
return Status::OK();
}
+const string& GroupCommitBlockSink::_get_max_disk_usage_dir(
Review Comment:
warning: method '_get_max_disk_usage_dir' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static const string& GroupCommitBlockSink::_get_max_disk_usage_dir(
```
##########
be/src/olap/wal_manager.cpp:
##########
@@ -166,6 +227,17 @@
return Status::OK();
}
+const string& WalManager::_get_min_disk_usage_wal_dir() {
Review Comment:
warning: method '_get_min_disk_usage_wal_dir' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static const string& WalManager::_get_min_disk_usage_wal_dir() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
