amorynan commented on code in PR #28233:
URL: https://github.com/apache/doris/pull/28233#discussion_r1424778949
##########
fe/fe-common/src/main/java/org/apache/doris/catalog/ArrayType.java:
##########
@@ -88,13 +88,14 @@ public boolean matchesType(Type t) {
return false;
}
- // Array(Null) is a virtual Array type, can match any Array(...) type
- if (itemType.isNull() || ((ArrayType) t).getItemType().isNull()) {
- return true;
+ if (!((ArrayType) t).getContainsNull() == getContainsNull()) {
+ return false;
}
- return itemType.matchesType(((ArrayType) t).itemType)
- && (((ArrayType) t).containsNull || !containsNull);
+ if (!itemType.matchesType(((ArrayType) t).itemType)) {
+ return false;
+ }
+ return true;
Review Comment:
make sense!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
