github-actions[bot] commented on code in PR #26537:
URL: https://github.com/apache/doris/pull/26537#discussion_r1418836855
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -460,11 +491,11 @@ Status
BetaRowsetWriter::flush_memtable(vectorized::Block* block, int32_t segmen
return Status::OK();
}
-Status BetaRowsetWriter::flush_single_block(const vectorized::Block* block) {
+Status BaseBetaRowsetWriter::flush_single_block(const vectorized::Block*
block) {
return _segment_creator.flush_single_block(block);
}
-Status BetaRowsetWriter::wait_flying_segcompaction() {
+Status BetaRowsetWriter::_wait_flying_segcompaction() {
Review Comment:
warning: method '_wait_flying_segcompaction' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/rowset/beta_rowset_writer.h:207:
```diff
- Status _wait_flying_segcompaction();
+ static Status _wait_flying_segcompaction();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
