github-actions[bot] commented on code in PR #28066:
URL: https://github.com/apache/doris/pull/28066#discussion_r1418673163
##########
be/src/vec/json/path_in_data.cpp:
##########
@@ -150,11 +150,18 @@ size_t PathInData::Hash::operator()(const PathInData&
value) const {
return hash.low ^ hash.high;
}
-PathInData PathInData::pop_front() const {
+PathInData PathInData::copy_pop_front() const {
+ return copy_pop_nfront(1);
+}
+
+PathInData PathInData::copy_pop_nfront(size_t n) const {
Review Comment:
warning: method 'copy_pop_nfront' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/json/path_in_data.h:78:
```diff
- PathInData copy_pop_nfront(size_t n) const;
+ static PathInData copy_pop_nfront(size_t n) ;
```
```suggestion
PathInData PathInData::copy_pop_nfront(size_t n) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
