HappenLee commented on code in PR #27943:
URL: https://github.com/apache/doris/pull/27943#discussion_r1417020946
##########
be/src/vec/core/block.cpp:
##########
@@ -577,7 +586,7 @@ MutableColumns Block::mutate_columns() {
size_t num_columns = data.size();
MutableColumns columns(num_columns);
for (size_t i = 0; i < num_columns; ++i) {
- columns[i] = data[i].column ?
(*std::move(data[i].column)).assume_mutable()
+ columns[i] = data[i].column ? (*std::move(data[i].column)).mutate()
Review Comment:
here maybe cause mutable column is different column in block，can not change
the mem in block cause result errror
##########
be/src/vec/core/block.cpp:
##########
@@ -577,7 +586,7 @@ MutableColumns Block::mutate_columns() {
size_t num_columns = data.size();
MutableColumns columns(num_columns);
for (size_t i = 0; i < num_columns; ++i) {
- columns[i] = data[i].column ?
(*std::move(data[i].column)).assume_mutable()
+ columns[i] = data[i].column ? (*std::move(data[i].column)).mutate()
Review Comment:
here maybe cause mutable column is different column in block，can not change
the mem in block cause result errror
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
