morrySnow commented on code in PR #28046:
URL: https://github.com/apache/doris/pull/28046#discussion_r1416646691
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -860,6 +860,7 @@ public PlanFragment visitPhysicalHashAggregate(
&& inputPlanFragment.getDataPartition().getType() !=
TPartitionType.RANDOM
&& aggregate.getAggregateParam().aggMode !=
AggMode.INPUT_TO_BUFFER) {
inputPlanFragment.setHasColocatePlanNode(true);
+ aggregationNode.setColocate(true);
Review Comment:
add comment to explain it please
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -771,7 +771,7 @@ public class SessionVariable implements Serializable,
Writable {
private boolean enableSharedScan = false;
@VariableMgr.VarAttr(name = ENABLE_LOCAL_SHUFFLE, fuzzy = false, varType =
VariableAnnotation.EXPERIMENTAL)
- private boolean enableLocalShuffle = false;
+ private boolean enableLocalShuffle = true;
Review Comment:
add description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
