github-actions[bot] commented on code in PR #27764:
URL: https://github.com/apache/doris/pull/27764#discussion_r1415212517


##########
be/src/service/internal_service.cpp:
##########
@@ -852,6 +855,114 @@ void PInternalServiceImpl::_get_column_ids_by_tablet_ids(
     response->mutable_status()->set_status_code(TStatusCode::OK);
 }
 
+template <class RPCResponse>
+struct AsyncRPCContext {
+    RPCResponse response;
+    brpc::Controller cntl;
+    brpc::CallId cid;
+};
+
+void 
PInternalServiceImpl::fetch_remote_tablet_schema(google::protobuf::RpcController*
 controller,

Review Comment:
   warning: function 'fetch_remote_tablet_schema' exceeds recommended 
size/complexity thresholds [readability-function-size]
   ```cpp
   void 
PInternalServiceImpl::fetch_remote_tablet_schema(google::protobuf::RpcController*
 controller,
                              ^
   ```
   <details>
   <summary>Additional context</summary>
   
   **be/src/service/internal_service.cpp:864:** 96 lines including whitespace 
and comments (threshold 80)
   ```cpp
   void 
PInternalServiceImpl::fetch_remote_tablet_schema(google::protobuf::RpcController*
 controller,
                              ^
   ```
   
   </details>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to