yiguolei commented on code in PR #27969:
URL: https://github.com/apache/doris/pull/27969#discussion_r1415092401
##########
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/QueryQueue.java:
##########
@@ -132,14 +128,29 @@ public QueueOfferToken offer() throws
InterruptedException {
}
}
- public void poll() throws InterruptedException {
- queueLock.tryLock(5, TimeUnit.SECONDS);
+ // If the token is acquired and do work success, then call this method to
release it.
+ public void returnToken(QueueToken token) throws InterruptedException {
Review Comment:
是不是不是dequeue，dequeue 是出队列的意思，我们是归还token
##########
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/QueryQueue.java:
##########
@@ -132,14 +128,29 @@ public QueueOfferToken offer() throws
InterruptedException {
}
}
- public void poll() throws InterruptedException {
- queueLock.tryLock(5, TimeUnit.SECONDS);
+ // If the token is acquired and do work success, then call this method to
release it.
+ public void returnToken(QueueToken token) throws InterruptedException {
Review Comment:
是不是不是dequeue，dequeue 是出队列的意思，我们是归还token
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
