github-actions[bot] commented on code in PR #28012:
URL: https://github.com/apache/doris/pull/28012#discussion_r1415088370
##########
be/src/olap/olap_server.cpp:
##########
@@ -1221,58 +1236,67 @@ int64_t
StorageEngine::get_pending_publish_min_version(int64_t tablet_id) {
return iter->second.begin()->first;
}
-void StorageEngine::_async_publish_callback() {
- while
(!_stop_background_threads_latch.wait_for(std::chrono::milliseconds(30))) {
- // tablet, publish_version
- std::vector<std::pair<TabletSharedPtr, int64_t>> need_removed_tasks;
- {
- std::lock_guard<std::mutex> lock(_async_publish_mutex);
- for (auto tablet_iter = _async_publish_tasks.begin();
- tablet_iter != _async_publish_tasks.end();) {
- if (tablet_iter->second.empty()) {
- tablet_iter = _async_publish_tasks.erase(tablet_iter);
- continue;
- }
- int64_t tablet_id = tablet_iter->first;
- TabletSharedPtr tablet =
tablet_manager()->get_tablet(tablet_id);
- if (!tablet) {
- LOG(WARNING) << "tablet does not exist when async publush,
tablet_id: "
- << tablet_id;
- tablet_iter = _async_publish_tasks.erase(tablet_iter);
- continue;
- }
+void StorageEngine::_process_async_publish() {
Review Comment:
warning: method '_process_async_publish' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/storage_engine.h:336:
```diff
- void _process_async_publish();
+ static void _process_async_publish();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
