zclllyybb commented on code in PR #27943:
URL: https://github.com/apache/doris/pull/27943#discussion_r1414970019
##########
be/src/vec/exec/scan/scanner_scheduler.cpp:
##########
@@ -384,10 +384,15 @@ void ScannerScheduler::_scanner_scan(ScannerScheduler*
scheduler, ScannerContext
ctx->return_free_block(std::move(block));
} else {
if (!blocks.empty() && blocks.back()->rows() + block->rows() <=
state->batch_size()) {
- status =
vectorized::MutableBlock(blocks.back().get()).merge(*block);
+ auto rows = blocks.back()->rows() + block->rows();
+ vectorized::MutableBlock mutable_block(blocks.back().get());
+ status = mutable_block.merge(*block);
if (!status.ok()) {
break;
}
+ if (!blocks.back().get()->is_valid(rows)) {
Review Comment:
Is there any situation that it's valid that block has columns with different
size? If not, maybe we can do this check in merging block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
