github-actions[bot] commented on code in PR #27967:
URL: https://github.com/apache/doris/pull/27967#discussion_r1413808667
##########
be/src/vec/exec/scan/vmeta_scanner.cpp:
##########
@@ -399,6 +405,44 @@ Status
VMetaScanner::_build_materialized_views_metadata_request(
return Status::OK();
}
+Status VMetaScanner::_build_jobs_metadata_request(const TMetaScanRange&
meta_scan_range,
Review Comment:
warning: method '_build_jobs_metadata_request' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/exec/scan/vmeta_scanner.h:85:
```diff
- Status _build_jobs_metadata_request(const TMetaScanRange&
meta_scan_range,
+ static Status _build_jobs_metadata_request(const TMetaScanRange&
meta_scan_range,
```
##########
be/src/vec/exec/scan/vmeta_scanner.cpp:
##########
@@ -399,6 +405,44 @@
return Status::OK();
}
+Status VMetaScanner::_build_jobs_metadata_request(const TMetaScanRange&
meta_scan_range,
+
TFetchSchemaTableDataRequest* request) {
+ VLOG_CRITICAL << "VMetaScanner::_build_jobs_metadata_request";
+ if (!meta_scan_range.__isset.jobs_params) {
+ return Status::InternalError("Can not find TJobsMetadataParams from
meta_scan_range.");
+ }
+
+ // create request
+ request->__set_schema_table_name(TSchemaTableName::METADATA_TABLE);
+
+ // create TMetadataTableRequestParams
+ TMetadataTableRequestParams metadata_table_params;
+ metadata_table_params.__set_metadata_type(TMetadataType::JOBS);
+
metadata_table_params.__set_jobs_metadata_params(meta_scan_range.jobs_params);
+
+ request->__set_metada_table_params(metadata_table_params);
+ return Status::OK();
+}
+
+Status VMetaScanner::_build_tasks_metadata_request(const TMetaScanRange&
meta_scan_range,
Review Comment:
warning: method '_build_tasks_metadata_request' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/exec/scan/vmeta_scanner.h:87:
```diff
- Status _build_tasks_metadata_request(const TMetaScanRange&
meta_scan_range,
+ static Status _build_tasks_metadata_request(const TMetaScanRange&
meta_scan_range,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
