github-actions[bot] commented on code in PR #27759:
URL: https://github.com/apache/doris/pull/27759#discussion_r1408956283


##########
be/src/olap/memtable_memory_limiter.cpp:
##########
@@ -59,135 +59,81 @@ void 
MemTableMemoryLimiter::register_writer(std::weak_ptr<MemTableWriter> writer
     _writers.push_back(writer);
 }
 
+bool MemTableMemoryLimiter::_soft_limit_reached() {

Review Comment:
   warning: function 'handle_memtable_flush' exceeds recommended 
size/complexity thresholds [readability-function-size]
   ```cpp
   void MemTableMemoryLimiter::handle_memtable_flush() {
                               ^
   ```
   <details>
   <summary>Additional context</summary>
   
   **be/src/olap/memtable_memory_limiter.cpp:61:** 153 lines including 
whitespace and comments (threshold 80)
   ```cpp
   void MemTableMemoryLimiter::handle_memtable_flush() {
                               ^
   ```
   
   </details>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to