morningman commented on code in PR #27626:
URL: https://github.com/apache/doris/pull/27626#discussion_r1405887622


##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -1366,6 +1369,12 @@ public void setEnableLeftZigZag(boolean 
enableLeftZigZag) {
                             + "tables larger than 
huge_table_lower_bound_size_in_bytes are analyzed only once."})
     public long hugeTableAutoAnalyzeIntervalInMillis = 
TimeUnit.HOURS.toMillis(12);
 
+    @VariableMgr.VarAttr(name = 
EXTERNAL_TABLE_AUTO_ANALYZE_INTERVAL_IN_MILLIS, flag = VariableMgr.GLOBAL,
+            description = {"控制对外表的自动ANALYZE的最小时间间隔,在该时间间隔内的外表仅ANALYZE一次",
+                    "This controls the minimum time interval for automatic 
ANALYZE on external tables."
+                        + "Within this interval, external tables are analyzed 
only once."})
+    public long externalTableAutoAnalyzeIntervalInMillis = 
TimeUnit.HOURS.toMillis(240);

Review Comment:
   10 days is too long



##########
fe/fe-core/src/main/java/org/apache/doris/statistics/util/StatisticsUtil.java:
##########
@@ -906,6 +906,16 @@ public static long 
getHugeTableAutoAnalyzeIntervalInMillis() {
         return StatisticConstants.HUGE_TABLE_AUTO_ANALYZE_INTERVAL_IN_MILLIS;
     }
 
+    public static long getExternalTableAutoAnalyzeIntervalInMillis() {
+        try {
+            return 
findConfigFromGlobalSessionVar(SessionVariable.EXTERNAL_TABLE_AUTO_ANALYZE_INTERVAL_IN_MILLIS)
+                .externalTableAutoAnalyzeIntervalInMillis;
+        } catch (Exception e) {
+            LOG.warn("Failed to get value of 
externalTableAutoAnalyzeIntervalInMillis, return default", e);

Review Comment:
   Why is an exception thrown here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to