wsjz commented on code in PR #27154:
URL: https://github.com/apache/doris/pull/27154#discussion_r1405548479


##########
fe/be-java-extensions/max-compute-scanner/src/main/java/org/apache/doris/maxcompute/MaxComputeJniScanner.java:
##########
@@ -173,6 +173,11 @@ public void open() throws IOException {
                     .collect(Collectors.toSet());
             List<Column> maxComputeColumns = new ArrayList<>(readColumns);
             maxComputeColumns.removeIf(e -> 
partitionColumns.contains(e.getName()));
+            if (maxComputeColumns.isEmpty() && !partitionColumns.isEmpty()) {

Review Comment:
   A select list contains columns and partition columns, we know columns can be 
empty.
   so if use count(*), maxComputeColumns can be empty,but partitionColumns not.
   
   Rename to pushDownColumns



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to