zclllyybb commented on code in PR #27565:
URL: https://github.com/apache/doris/pull/27565#discussion_r1404803530
##########
be/src/vec/exec/join/vnested_loop_join_node.cpp:
##########
@@ -347,8 +347,8 @@ void
VNestedLoopJoinNode::_process_left_child_block(MutableBlock& mutable_block,
void VNestedLoopJoinNode::_update_additional_flags(Block* block) {
if (_is_outer_join) {
- auto p0 = _tuple_is_null_left_flag_column->assume_mutable();
Review Comment:
for a column which would be reused, shouldn't use `assume_mutable()` to move
its ownership. `mutate()` will check its' ownership by `ref_count` in it. then
decide to use `assume_mutable()` or `clone()`. so it's always safe.
In this situation, `assume_mutable` lead to a low probability double release
which clearly showed in our coredump file. so fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
