EmmyMiao87 commented on a change in pull request #5521: URL: https://github.com/apache/incubator-doris/pull/5521#discussion_r601119477
########## File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java ########## @@ -235,8 +235,8 @@ @VariableMgr.VarAttr(name = DISABLE_STREAMING_PREAGGREGATIONS) public boolean disableStreamPreaggregations = false; - @VariableMgr.VarAttr(name = DISABLE_COLOCATE_JOIN) - public boolean disableColocateJoin = false; + @VariableMgr.VarAttr(name = DISABLE_COLOCATE_PLAN) + public boolean disableColocatePlan = false; Review comment: Because the previous configuration name is ```colocate join```. It only controls the colocate of the join. Now this new configuration uniformly controls the colocate of all plan node. So it would be too one-sided to call ```colocate join```. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org