yangzhg commented on a change in pull request #5394:
URL: https://github.com/apache/incubator-doris/pull/5394#discussion_r595708877
##########
File path: be/CMakeLists.txt
##########
@@ -130,11 +130,12 @@ endif()
set(Boost_DEBUG FALSE)
set(Boost_USE_MULTITHREADED ON)
set(BOOST_ROOT ${THIRDPARTY_DIR})
+set(Boost_NO_BOOST_CMAKE OFF)
if (NOT APPLE)
- find_package(Boost 1.55.0 REQUIRED COMPONENTS thread regex filesystem
system date_time program_options)
+ find_package(Boost 1.73.0 REQUIRED COMPONENTS regex system filesystem
thread date_time program_options)
else()
- find_package(Boost 1.55.0 COMPONENTS thread regex filesystem system
date_time program_options)
+ find_package(Boost 1.73.0 COMPONENTS thread regex system filesystem
date_time program_options)
endif()
include_directories(${Boost_INCLUDE_DIRS})
message(STATUS ${Boost_LIBRARIES})
Review comment:
this line shoud removed when use find_package boost, and should use
Boost::thread etc. in DORIS_DEPENDENCIES instead of $Boost_LIBRARIES
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
