xiaokang commented on code in PR #27299:
URL: https://github.com/apache/doris/pull/27299#discussion_r1399967718
##########
be/src/olap/cumulative_compaction_time_series_policy.cpp:
##########
@@ -70,6 +70,12 @@ uint32_t
TimeSeriesCumulativeCompactionPolicy::calc_cumulative_compaction_score(
return score;
}
+ // If their are many empty rowset, maybe should be compact
+ auto consecutive_empty_rowsets =
tablet->collect_consecutive_empty_rowsets();
Review Comment:
maybe we should treat it as condition 4 and put it in the last
##########
be/src/olap/cumulative_compaction_time_series_policy.cpp:
##########
@@ -229,6 +242,14 @@ int
TimeSeriesCumulativeCompactionPolicy::pick_input_rowsets(
return transient_size;
}
+ auto consecutive_empty_rowsets =
tablet->collect_consecutive_empty_rowsets();
Review Comment:
maybe we should treat it as condition 4 and put it in the last
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
