amorynan commented on code in PR #26534: URL: https://github.com/apache/doris/pull/26534#discussion_r1399957628
########## be/src/vec/data_types/serde/data_type_ipv4_serde.h: ########## @@ -46,6 +46,10 @@ class DataTypeIPv4SerDe : public DataTypeNumberSerDe<IPv4> { int row_idx, bool col_const) const override; Status write_column_to_mysql(const IColumn& column, MysqlRowBuffer<false>& row_buffer, int row_idx, bool col_const) const override; + Status serialize_one_cell_to_json(const IColumn& column, int row_num, BufferWritable& bw, Review Comment: why here has impl serialize_column_to_json/deserialize_column_from_json -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org