eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1393618580
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -276,7 +282,12 @@ Status SegmentIterator::_init_impl(const
StorageReadOptions& opts) {
_file_reader = _segment->_file_reader;
_opts = opts;
_col_predicates.clear();
+
for (auto& predicate : opts.column_predicates) {
+ if (!_segment->can_apply_predicate_safely(predicate->column_id(),
predicate, *_schema,
+ _opts.io_ctx.reader_type)) {
+ continue;
Review Comment:
Now it's safe, since only variant's predicate will `continue` here, and let
the expr to handle such filter like inverted index `match` does.It could be a
common usage for later `light schema change data type`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
