caiconghui commented on a change in pull request #5395:
URL: https://github.com/apache/incubator-doris/pull/5395#discussion_r584452306
##########
File path: fe/fe-core/src/main/java/org/apache/doris/alter/Alter.java
##########
@@ -230,16 +230,6 @@ public void processAlterTable(AlterTableStmt stmt) throws
UserException {
List<AlterClause> alterClauses = Lists.newArrayList();
// some operations will take long time to process, need to be done
outside the table lock
boolean needProcessOutsideTableLock = false;
-
- // check conflict alter ops first
Review comment:
> Why do we needn't check conflict alter ops first?
alterClauses is always empty here, so check conflict alter ops makes no
sense here. in processAlterOlapTable and processAlterExternalTable will check
conflict alter ops
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
