yiguolei commented on code in PR #26191:
URL: https://github.com/apache/doris/pull/26191#discussion_r1386208584
##########
be/src/vec/columns/column_vector.h:
##########
@@ -198,10 +198,10 @@ class ColumnVector final : public
COWHelper<ColumnVectorHelper, ColumnVector<T>>
void insert_date_column(const char* data_ptr, size_t num) {
data.reserve(data.size() + num);
- size_t input_value_size = sizeof(uint24_t);
+ constexpr size_t input_value_size = sizeof(uint24_t);
for (int i = 0; i < num; i++) {
- uint64_t val = 0;
+ uint24_t val = 0;
Review Comment:
我估计啊，你这么改性能不一定高， 这个24bit 不对齐，可能都不如直接uint32_t
##########
be/src/vec/columns/column_vector.h:
##########
@@ -198,10 +198,10 @@ class ColumnVector final : public
COWHelper<ColumnVectorHelper, ColumnVector<T>>
void insert_date_column(const char* data_ptr, size_t num) {
data.reserve(data.size() + num);
- size_t input_value_size = sizeof(uint24_t);
+ constexpr size_t input_value_size = sizeof(uint24_t);
for (int i = 0; i < num; i++) {
- uint64_t val = 0;
+ uint24_t val = 0;
Review Comment:
我估计啊，你这么改性能不一定高， 这个24bit 不对齐，可能都不如直接uint32_t
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
