github-actions[bot] commented on code in PR #26483:
URL: https://github.com/apache/doris/pull/26483#discussion_r1383400330
##########
be/src/olap/wal_writer.cpp:
##########
@@ -25,7 +26,9 @@
namespace doris {
-WalWriter::WalWriter(const std::string& file_name) : _file_name(file_name) {}
+WalWriter::WalWriter(const std::string& file_name,
Review Comment:
warning: pass by value and use std::move [modernize-pass-by-value]
be/src/olap/wal_writer.cpp:18:
```diff
+
+ #include <utility>
```
```suggestion
WalWriter::WalWriter(std::string file_name,
```
be/src/olap/wal_writer.cpp:30:
```diff
- : _file_name(file_name), _all_wal_disk_bytes(all_wal_disk_bytes) {}
+ : _file_name(std::move(file_name)),
_all_wal_disk_bytes(all_wal_disk_bytes) {}
```
be/src/olap/wal_writer.h:33:
```diff
- explicit WalWriter(const std::string& file_name,
+ explicit WalWriter(std::string file_name,
```
##########
be/src/olap/wal_manager.h:
##########
@@ -15,6 +15,8 @@
// specific language governing permissions and limitations
// under the License.
+#include <memory>
+
#include "common/config.h"
#include "gen_cpp/FrontendService.h"
Review Comment:
warning: 'gen_cpp/FrontendService.h' file not found [clang-diagnostic-error]
```cpp
#include "gen_cpp/FrontendService.h"
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
