github-actions[bot] commented on code in PR #26357:
URL: https://github.com/apache/doris/pull/26357#discussion_r1382312752
##########
be/src/vec/sink/load_stream_stub.cpp:
##########
@@ -84,30 +84,41 @@ void
LoadStreamStub::LoadStreamReplyHandler::on_closed(brpc::StreamId id) {
}
LoadStreamStub::LoadStreamStub(PUniqueId load_id, int64_t src_id)
- : _load_id(load_id),
+ : _is_init(false),
+ _load_id(load_id),
_src_id(src_id),
_tablet_schema_for_index(std::make_shared<IndexToTabletSchema>()),
- _enable_unique_mow_for_index(std::make_shared<IndexToEnableMoW>())
{};
+ _enable_unique_mow_for_index(std::make_shared<IndexToEnableMoW>()) {}
LoadStreamStub::LoadStreamStub(LoadStreamStub& stub)
- : _load_id(stub._load_id),
+ : _is_init(stub._is_init.load()),
+ _load_id(stub._load_id),
_src_id(stub._src_id),
_tablet_schema_for_index(stub._tablet_schema_for_index),
- _enable_unique_mow_for_index(stub._enable_unique_mow_for_index) {};
+ _enable_unique_mow_for_index(stub._enable_unique_mow_for_index) {}
LoadStreamStub::~LoadStreamStub() {
if (_is_init.load() && !_handler.is_closed()) {
brpc::StreamClose(_stream_id);
}
}
+Status LoadStreamStub::prepare() {
Review Comment:
warning: method 'prepare' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/sink/load_stream_stub.h:147:
```diff
- Status prepare();
+ static Status prepare();
```
##########
be/src/vec/sink/vtablet_sink_v2.cpp:
##########
@@ -165,35 +173,41 @@ Status VOlapTableSinkV2::open(RuntimeState* state) {
SCOPED_CONSUME_MEM_TRACKER(_mem_tracker.get());
signal::set_signal_task_id(_load_id);
- _build_tablet_node_mapping();
- RETURN_IF_ERROR(_open_streams(state->backend_id()));
-
+ RETURN_IF_ERROR(_open_streams());
return Status::OK();
}
-Status VOlapTableSinkV2::_open_streams(int64_t src_id) {
+Status VOlapTableSinkV2::_init_streams(int64_t src_id) {
Review Comment:
warning: method '_init_streams' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/sink/vtablet_sink_v2.h:134:
```diff
- Status _init_streams(int64_t src_id);
+ static Status _init_streams(int64_t src_id);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
