amorynan commented on code in PR #26270:
URL: https://github.com/apache/doris/pull/26270#discussion_r1379540259
##########
fe/fe-common/src/main/java/org/apache/doris/catalog/Type.java:
##########
@@ -787,9 +788,49 @@ public static Type getAssignmentCompatibleType(Type t1,
Type t2, boolean strict)
}
return new ArrayType(itemCompatibleType,
arrayType1.getContainsNull() || arrayType2.getContainsNull());
- } else if (t1.isArrayType() && t2.isNull()) {
+ } else if (t1.isMapType() && t2.isMapType()) {
+ MapType mapType1 = (MapType) t1;
+ MapType mapType2 = (MapType) t2;
+ Type keyCompatibleType =
Type.getAssignmentCompatibleType(mapType1.getKeyType(),
+ mapType2.getKeyType(), strict);
+ if (keyCompatibleType.isInvalid()) {
+ return keyCompatibleType;
Review Comment:
here keyCompatibleType equals Invalid Type, so just return InvalidType
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
