Dragonliu2018 commented on code in PR #26133:
URL: https://github.com/apache/doris/pull/26133#discussion_r1377072347
##########
be/test/common/status_test.cpp:
##########
@@ -73,4 +73,10 @@ TEST_F(StatusTest, Error) {
}
}
+TEST_F(StatusTest /*unused*/, Format /*unused*/) {
+ // default
+ Status st;
Review Comment:
Whether status contains stacktrace is determined by the preprocessor macro
`ENABLE_STACKTRACE`. So for cases 2 and 3, I just need to test `status ==
error`, not care stacktrace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
