xiaokang commented on code in PR #26080:
URL: https://github.com/apache/doris/pull/26080#discussion_r1375758496
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -1040,6 +1043,55 @@ Status SegmentIterator::_apply_inverted_index() {
}
}
}
+
+ // delete from _common_expr_ctxs_push_down if a MATCH predicate will be
removed from _col_predicates
+ // since it's not necessary to eval it any more to avoid index miss, which
is added in _normalize_predicate
+ for (auto pred : _col_predicates) {
+ if (pred->type() == PredicateType::MATCH &&
+ std::find(remaining_predicates.begin(),
remaining_predicates.end(), pred) ==
+ remaining_predicates.end()) {
+ MatchPredicate* match_pred = dynamic_cast<MatchPredicate*>(pred);
Review Comment:
add check for safety at present and change it to static_cast in the future.
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -1040,6 +1043,55 @@ Status SegmentIterator::_apply_inverted_index() {
}
}
}
+
+ // delete from _common_expr_ctxs_push_down if a MATCH predicate will be
removed from _col_predicates
+ // since it's not necessary to eval it any more to avoid index miss, which
is added in _normalize_predicate
+ for (auto pred : _col_predicates) {
+ if (pred->type() == PredicateType::MATCH &&
+ std::find(remaining_predicates.begin(),
remaining_predicates.end(), pred) ==
+ remaining_predicates.end()) {
+ MatchPredicate* match_pred = dynamic_cast<MatchPredicate*>(pred);
+ for (auto it = _common_expr_ctxs_push_down.begin();
+ it != _common_expr_ctxs_push_down.end(); it++) {
+ auto expr = (*it)->root().get();
+ // check expr type and child is the same as match predicate
+ if (expr->node_type() == TExprNodeType::MATCH_PRED &&
+ expr->children().size() == 2 &&
expr->get_child(0)->is_slot_ref() &&
+ expr->get_child(1)->is_constant()) {
+ auto slot_ref =
dynamic_cast<vectorized::VSlotRef*>(expr->get_child(0).get());
Review Comment:
add check for safety at present and change it to static_cast in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
