XieJiann commented on code in PR #26084:
URL: https://github.com/apache/doris/pull/26084#discussion_r1375622009
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/pattern/GroupMatching.java:
##########
@@ -45,11 +45,12 @@ public static List<Plan> getAllMatchingPlans(Pattern
pattern, Group group) {
matchingPlans.add(plan);
}
}
- for (GroupExpression groupExpression :
group.getPhysicalExpressions()) {
- for (Plan plan : new GroupExpressionMatching(pattern,
groupExpression)) {
- matchingPlans.add(plan);
- }
- }
+ // Jackwener: We don't need to match physical expressions.
+ // for (GroupExpression groupExpression :
group.getPhysicalExpressions()) {
+ // for (Plan plan : new GroupExpressionMatching(pattern,
groupExpression)) {
+ // matchingPlans.add(plan);
+ // }
+ // }
Review Comment:
remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
