github-actions[bot] commented on code in PR #26081:
URL: https://github.com/apache/doris/pull/26081#discussion_r1375431376
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -1612,10 +1661,82 @@
}
}
+bool SegmentIterator::_is_all_invert_index_read() {
+ if (_opts.tablet_schema->keys_type() != KeysType::DUP_KEYS) {
+ return false;
+ }
+
+ if (_opts.push_down_agg_type_opt != TPushAggOp::COUNT_ON_INDEX) {
+ return false;
+ }
+
+ if (_all_invert_index_read == 0 || _all_predicate_count_ == 0) {
+ return false;
+ }
+
+ if (!_is_output_in_predicate) {
+ return false;
+ }
+
+ if (_all_invert_index_read != _all_predicate_count_) {
+ return false;
+ }
+
+ return true;
+}
+
+bool SegmentIterator::_is_read_real_data() {
+ if (_opts.read_orderby_key_reverse) {
+ return false;
+ }
+
+ if (_is_need_vec_eval || _is_need_short_eval || _is_need_expr_eval) {
+ return false;
+ }
+
+ return true;
+}
+
+bool SegmentIterator::_read_default_data(uint32_t nrows_read_limit, uint32_t&
nrows_read) {
Review Comment:
warning: method '_read_default_data' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/rowset/segment_v2/segment_iterator.h:269:
```diff
- bool _read_default_data(uint32_t nrows_read_limit, uint32_t&
nrows_read);
+ static bool _read_default_data(uint32_t nrows_read_limit, uint32_t&
nrows_read);
```
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -1612,10 +1661,82 @@ void
SegmentIterator::_output_non_pred_columns(vectorized::Block* block) {
}
}
+bool SegmentIterator::_is_all_invert_index_read() {
Review Comment:
warning: method '_is_all_invert_index_read' can be made const
[readability-make-member-function-const]
```suggestion
bool SegmentIterator::_is_all_invert_index_read() const {
```
be/src/olap/rowset/segment_v2/segment_iterator.h:267:
```diff
- bool _is_all_invert_index_read();
+ bool _is_all_invert_index_read() const;
```
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -1612,10 +1661,82 @@
}
}
+bool SegmentIterator::_is_all_invert_index_read() {
+ if (_opts.tablet_schema->keys_type() != KeysType::DUP_KEYS) {
+ return false;
+ }
+
+ if (_opts.push_down_agg_type_opt != TPushAggOp::COUNT_ON_INDEX) {
+ return false;
+ }
+
+ if (_all_invert_index_read == 0 || _all_predicate_count_ == 0) {
+ return false;
+ }
+
+ if (!_is_output_in_predicate) {
+ return false;
+ }
+
+ if (_all_invert_index_read != _all_predicate_count_) {
+ return false;
+ }
+
+ return true;
+}
+
+bool SegmentIterator::_is_read_real_data() {
Review Comment:
warning: method '_is_read_real_data' can be made const
[readability-make-member-function-const]
```suggestion
bool SegmentIterator::_is_read_real_data() const {
```
be/src/olap/rowset/segment_v2/segment_iterator.h:268:
```diff
- bool _is_read_real_data();
+ bool _is_read_real_data() const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
