acelyc111 commented on a change in pull request #5124:
URL: https://github.com/apache/incubator-doris/pull/5124#discussion_r554294341
##########
File path: be/src/olap/olap_server.cpp
##########
@@ -390,7 +379,7 @@ void StorageEngine::_compaction_tasks_producer_callback() {
} else {
sleep(config::check_auto_compaction_interval_seconds);
}
- }
+ } while
(!_stop_background_threads_latch.wait_for(MonoDelta::FromMilliseconds(interval)));
Review comment:
Need to call `THREAD_JOIN(_compaction_tasks_producer_thread);` in
StorageEngine::stop(), otherwise it's still unsafe as described in
https://github.com/apache/incubator-doris/issues/5213
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
