morrySnow commented on code in PR #25751:
URL: https://github.com/apache/doris/pull/25751#discussion_r1368565494
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Add.java:
##########
@@ -49,7 +49,7 @@ public Expression withChildren(List<Expression> children) {
@Override
public DecimalV3Type getDataTypeForDecimalV3(DecimalV3Type t1,
DecimalV3Type t2) {
- return (DecimalV3Type) DecimalV3Type.widerDecimalV3Type(t1, t2, false);
+ return (DecimalV3Type) DecimalV3Type.widerDecimalV3TypeForAddSub(t1,
t2, false);
Review Comment:
do not change widerDecimalV3TypeForAddSub directly, use
widerDecimalV3TypeForAddSub's result and plus 1 on its precision to create a
new DecimalV3Type object
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
