zhiqiang-hhhh commented on code in PR #25739:
URL: https://github.com/apache/doris/pull/25739#discussion_r1368280334


##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -451,8 +452,13 @@ void 
FragmentMgr::_exec_actual(std::shared_ptr<PlanFragmentExecutor> fragment_ex
     {
         std::lock_guard<std::mutex> lock(_lock);
         _fragment_map.erase(fragment_executor->fragment_instance_id());
+        LOG_INFO("Instance {} finished",
+                 PrintInstanceStandardInfo(fragment_executor->query_id(),
+                                           fragment_executor->fragment_id(),

Review Comment:
   没有 fragment id 的话没法判断instance是不是属于同一个fragment啊



##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -451,8 +452,13 @@ void 
FragmentMgr::_exec_actual(std::shared_ptr<PlanFragmentExecutor> fragment_ex
     {
         std::lock_guard<std::mutex> lock(_lock);
         _fragment_map.erase(fragment_executor->fragment_instance_id());
+        LOG_INFO("Instance {} finished",
+                 PrintInstanceStandardInfo(fragment_executor->query_id(),
+                                           fragment_executor->fragment_id(),

Review Comment:
   没有 fragment id 的话没法判断instance是不是属于同一个fragment啊



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to