Mryange commented on code in PR #25585: URL: https://github.com/apache/doris/pull/25585#discussion_r1365157996
########## be/src/pipeline/pipeline_x/operator.h: ########## @@ -21,25 +21,25 @@ namespace doris::pipeline { -#define CREATE_LOCAL_STATE_RETURN_IF_ERROR(local_state) \ - auto _sptr = state->get_local_state(id()); \ - if (!_sptr) return Status::InternalError("could not find local state id {}", id()); \ - auto& local_state = _sptr->template cast<LocalState>(); - -#define CREATE_SINK_LOCAL_STATE_RETURN_IF_ERROR(local_state) \ - auto _sptr = state->get_sink_local_state(id()); \ - if (!_sptr) return Status::InternalError("could not find local state id {}", id()); \ - auto& local_state = _sptr->template cast<LocalState>(); - -#define CREATE_LOCAL_STATE_RETURN_NULL_IF_ERROR(local_state) \ - auto _sptr = state->get_local_state(id()); \ - if (!_sptr) return nullptr; \ - auto& local_state = _sptr->template cast<LocalState>(); - -#define CREATE_SINK_LOCAL_STATE_RETURN_NULL_IF_ERROR(local_state) \ - auto _sptr = state->get_sink_local_state(id()); \ - if (!_sptr) return nullptr; \ - auto& local_state = _sptr->template cast<LocalState>(); +#define CREATE_LOCAL_STATE_RETURN_STATUS_IF_ERROR(local_state) \ Review Comment: But this is used to create the local_state variable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org