eldenmoon commented on code in PR #24603:
URL: https://github.com/apache/doris/pull/24603#discussion_r1363022453
##########
be/src/vec/sink/vmemory_scratch_sink.cpp:
##########
@@ -75,13 +76,18 @@ Status MemoryScratchSink::prepare(RuntimeState* state) {
return Status::OK();
}
-Status MemoryScratchSink::send(RuntimeState* state, Block* block, bool eos) {
- if (nullptr == block || 0 == block->rows()) {
+Status MemoryScratchSink::send(RuntimeState* state, Block* input_block, bool
eos) {
+ if (nullptr == input_block || 0 == input_block->rows()) {
return Status::OK();
}
std::shared_ptr<arrow::RecordBatch> result;
+ // Exec vectorized expr here to speed up, block.rows() == 0 means expr exec
+ // failed, just return the error status
+ Block block;
+
RETURN_IF_ERROR(VExprContext::get_output_block_after_execute_exprs(_output_vexpr_ctxs,
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
