github-actions[bot] commented on code in PR #25435:
URL: https://github.com/apache/doris/pull/25435#discussion_r1361906118
##########
be/src/pipeline/exec/operator.h:
##########
@@ -174,6 +174,14 @@ class OperatorBase {
virtual bool is_source() const;
+ virtual Status collect_query_statistics(QueryStatistics* statistics) {
return Status::OK(); };
+
+ virtual Status collect_query_statistics(QueryStatistics* statistics, int
sender_id) {
+ return Status::OK();
+ };
+
+ virtual void set_query_statistics(std::shared_ptr<QueryStatistics>) {};
Review Comment:
warning: all parameters should be named in a function
[readability-named-parameter]
```suggestion
virtual void set_query_statistics(std::shared_ptr<QueryStatistics>
/*unused*/) {};
```
##########
be/src/vec/exec/scan/new_olap_scan_node.cpp:
##########
@@ -82,13 +82,18 @@ NewOlapScanNode::NewOlapScanNode(ObjectPool* pool, const
TPlanNode& tnode,
Status NewOlapScanNode::collect_query_statistics(QueryStatistics* statistics) {
RETURN_IF_ERROR(ExecNode::collect_query_statistics(statistics));
if (!_is_pipeline_scan || _should_create_scanner) {
- statistics->add_scan_bytes(_read_compressed_counter->value());
- statistics->add_scan_rows(_raw_rows_counter->value());
+ statistics->add_scan_bytes(_byte_read_counter->value());
+ statistics->add_scan_rows(_rows_read_counter->value());
statistics->add_cpu_ms(_scan_cpu_timer->value() / NANOS_PER_MILLIS);
}
return Status::OK();
}
+Status NewOlapScanNode::collect_query_statistics(QueryStatistics* statistics,
int) {
Review Comment:
warning: all parameters should be named in a function
[readability-named-parameter]
```suggestion
Status NewOlapScanNode::collect_query_statistics(QueryStatistics*
statistics, int /*sender_id*/) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
