github-actions[bot] commented on code in PR #25510: URL: https://github.com/apache/doris/pull/25510#discussion_r1361585894
########## be/src/vec/common/format_ip.h: ########## @@ -31,6 +33,9 @@ constexpr size_t IPV4_BINARY_LENGTH = 4; constexpr size_t IPV4_MAX_TEXT_LENGTH = 15; /// Does not count tail zero byte. constexpr size_t IPV4_MIN_NUM_VALUE = 0; //num value of '0.0.0.0' constexpr size_t IPV4_MAX_NUM_VALUE = 4294967295; //num value of '255.255.255.255' ++constexpr size_t IPV4_MAX_OCTET_VALUE = 255; //max vulue of octet Review Comment: warning: expected external declaration [clang-diagnostic-error] ```cpp +constexpr size_t IPV4_MAX_OCTET_VALUE = 255; //max vulue of octet ^ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
