github-actions[bot] commented on code in PR #25480:
URL: https://github.com/apache/doris/pull/25480#discussion_r1360714148
##########
be/src/vec/sink/vtablet_block_convertor.h:
##########
@@ -66,15 +66,15 @@ class OlapTableBlockConvertor {
Status _validate_column(RuntimeState* state, const TypeDescriptor& type,
bool is_nullable,
vectorized::ColumnPtr column, size_t slot_index,
bool* stop_processing,
- fmt::memory_buffer& error_prefix,
+ fmt::memory_buffer& error_prefix, const uint32_t
row_count,
Review Comment:
warning: parameter 'row_count' is const-qualified in the function
declaration; const-qualification of parameters only has an effect in function
definitions [readability-avoid-const-params-in-decls]
```suggestion
fmt::memory_buffer& error_prefix, uint32_t
row_count,
```
##########
be/src/vec/sink/vtablet_block_convertor.h:
##########
@@ -66,15 +66,15 @@ class OlapTableBlockConvertor {
Status _validate_column(RuntimeState* state, const TypeDescriptor& type,
bool is_nullable,
vectorized::ColumnPtr column, size_t slot_index,
bool* stop_processing,
- fmt::memory_buffer& error_prefix,
+ fmt::memory_buffer& error_prefix, const uint32_t
row_count,
vectorized::IColumn::Permutation* rows = nullptr);
// make input data valid for OLAP table
// return number of invalid/filtered rows.
// invalid row number is set in Bitmap
// set stop_processing if we want to stop the whole process now.
- Status _validate_data(RuntimeState* state, vectorized::Block* block,
int64_t& filtered_rows,
- bool* stop_processing);
+ Status _validate_data(RuntimeState* state, vectorized::Block* block, const
uint32_t rows,
Review Comment:
warning: parameter 'rows' is const-qualified in the function declaration;
const-qualification of parameters only has an effect in function definitions
[readability-avoid-const-params-in-decls]
```suggestion
Status _validate_data(RuntimeState* state, vectorized::Block* block,
uint32_t rows,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
