github-actions[bot] commented on code in PR #25481:
URL: https://github.com/apache/doris/pull/25481#discussion_r1360424201
##########
be/src/pipeline/pipeline_x/operator.cpp:
##########
@@ -159,6 +159,8 @@ Status OperatorXBase::close(RuntimeState* state) {
if (_child_x && !is_source()) {
RETURN_IF_ERROR(_child_x->close(state));
}
+ auto local_state = state->get_local_state(id());
+ if (!local_state) return Status::OK();
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (!local_state) { return Status::OK();
}
```
##########
be/src/pipeline/pipeline_x/operator.h:
##########
@@ -478,6 +497,8 @@ class DataSinkOperatorXBase : public OperatorBase {
[[nodiscard]] bool is_source() const override { return false; }
virtual Status close(RuntimeState* state, Status exec_status) {
+ auto local_state = state->get_sink_local_state(id());
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (!local_state) { return Status::OK();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
