englefly commented on code in PR #25193:
URL: https://github.com/apache/doris/pull/25193#discussion_r1358086312
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/PhysicalHashJoin.java:
##########
@@ -140,32 +138,32 @@ public <R, C> R accept(PlanVisitor<R, C> visitor, C
context) {
return visitor.visitPhysicalHashJoin(this, context);
}
- @Override
- public String toString() {
- List<Object> args = Lists.newArrayList("type", joinType,
Review Comment:
yes, move to its parent class
LogicalHashJoin and physical hash join share the same toString() fucntion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
