freemandealer commented on code in PR #25293:
URL: https://github.com/apache/doris/pull/25293#discussion_r1356027067
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -515,7 +516,8 @@ RowsetSharedPtr BetaRowsetWriter::build() {
}
if (_segcompaction_worker.get_file_writer()) {
-
static_cast<void>(_segcompaction_worker.get_file_writer()->close());
+ WARN_IF_ERROR(_segcompaction_worker.get_file_writer()->close(),
Review Comment:
Printing a warning here would not be enough. Since data may not be synced to
disk if file writers close fail, causing data corruption in silence. I suggest
we should return nullptr if shit happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
