englefly commented on code in PR #25167:
URL: https://github.com/apache/doris/pull/25167#discussion_r1350181161
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/CountByEnum.java:
##########
@@ -35,20 +33,24 @@
public class CountByEnum extends AggregateFunction implements
ExplicitlyCastableSignature, AlwaysNotNullable {
public static final List<FunctionSignature> SIGNATURES = ImmutableList.of(
-
FunctionSignature.ret(ArrayType.of(StringType.INSTANCE)).args(StringType.INSTANCE)
+
FunctionSignature.ret(StringType.INSTANCE).varArgs(StringType.INSTANCE)
);
- /**
- * constructor with 1 or more arguments.
- */
- public CountByEnum(Expression arg, Expression... varArgs) {
- super("count_by_enum", ExpressionUtils.mergeArguments(arg, varArgs));
+ public CountByEnum(Expression arg0, Expression... varArgs) {
+ super("count_by_enum", ExpressionUtils.mergeArguments(arg0, varArgs));
+ }
+
+ public CountByEnum(boolean distinct, Expression arg0, Expression...
varArgs) {
+ super("count_by_enum", true, ExpressionUtils.mergeArguments(arg0,
varArgs));
Review Comment:
why "distinct" always true, even caller set distinct=false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
