eldenmoon commented on code in PR #24554:
URL: https://github.com/apache/doris/pull/24554#discussion_r1336911982
##########
be/src/vec/olap/olap_data_convertor.cpp:
##########
@@ -587,28 +594,17 @@ const void*
OlapBlockDataConvertor::OlapColumnDataConvertorVarChar::get_data_at(
return null_flag ? nullptr : _slice.data() + offset;
}
-Status
OlapBlockDataConvertor::OlapColumnDataConvertorVarChar::convert_to_olap() {
- assert(_typed_column.column);
- const vectorized::ColumnString* column_string = nullptr;
- if (_nullmap) {
- auto nullable_column =
- assert_cast<const
vectorized::ColumnNullable*>(_typed_column.column.get());
- column_string = assert_cast<const vectorized::ColumnString*>(
- nullable_column->get_nested_column_ptr().get());
- } else {
- column_string = assert_cast<const
vectorized::ColumnString*>(_typed_column.column.get());
- }
-
+Status OlapBlockDataConvertor::OlapColumnDataConvertorVarChar::convert_to_olap(
Review Comment:
extract the common component used for `OlapColumnDataConvertorVariant`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
