JackDrogon commented on code in PR #24834:
URL: https://github.com/apache/doris/pull/24834#discussion_r1335654525
##########
be/src/olap/snapshot_manager.cpp:
##########
@@ -160,6 +161,9 @@ Status SnapshotManager::convert_rowset_ids(const
std::string& clone_dir, int64_t
new_tablet_meta_pb.set_tablet_id(tablet_id);
*new_tablet_meta_pb.mutable_tablet_uid() = TabletUid::gen_uid().to_proto();
new_tablet_meta_pb.set_replica_id(replica_id);
+ if (partition_id != -1) {
Review Comment:
这个我突然感觉用optional<int64_t>更好些
##########
be/src/olap/snapshot_manager.cpp:
##########
@@ -160,6 +161,9 @@ Status SnapshotManager::convert_rowset_ids(const
std::string& clone_dir, int64_t
new_tablet_meta_pb.set_tablet_id(tablet_id);
*new_tablet_meta_pb.mutable_tablet_uid() = TabletUid::gen_uid().to_proto();
new_tablet_meta_pb.set_replica_id(replica_id);
+ if (partition_id != -1) {
Review Comment:
这个我突然感觉用optional<int64_t>更好些
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
