BePPPower commented on code in PR #24393:
URL: https://github.com/apache/doris/pull/24393#discussion_r1332729373
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/EsExternalCatalog.java:
##########
@@ -44,6 +45,9 @@ public class EsExternalCatalog extends ExternalCatalog {
private static final Logger LOG =
LogManager.getLogger(EsExternalCatalog.class);
private EsRestClient esRestClient;
+ private static final List<String> REQUIRED_PROPERTIES = Lists.newArrayList(
+ EsResource.HOSTS
+ );
Review Comment:
Maybe it is better to use `ImmutableList` or `ImmutableSet`？The same goes
for other `REQUIRED PROPERTIES`.
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/EsExternalCatalog.java:
##########
@@ -44,6 +45,9 @@ public class EsExternalCatalog extends ExternalCatalog {
private static final Logger LOG =
LogManager.getLogger(EsExternalCatalog.class);
private EsRestClient esRestClient;
+ private static final List<String> REQUIRED_PROPERTIES = Lists.newArrayList(
+ EsResource.HOSTS
+ );
Review Comment:
Maybe it is better to use `ImmutableList` or `ImmutableSet`？The same goes
for other `REQUIRED PROPERTIES`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
