yiguolei commented on code in PR #23793:
URL: https://github.com/apache/doris/pull/23793#discussion_r1317132116
##########
be/src/olap/delete_handler.cpp:
##########
@@ -71,6 +74,9 @@ Status DeleteHandler::generate_delete_predicate(const
TabletSchema& schema,
for (const TCondition& condition : conditions) {
if (condition.condition_values.size() > 1) {
InPredicatePB* in_pred = del_pred->add_in_predicates();
+ if (condition.__isset.column_unique_id) {
+ in_pred->set_column_unique_id(condition.column_unique_id);
Review Comment:
这里的condition 的 unique id 不一定被设置了吧？ 如果没设置，此时是不是即使是v2 ，那么也没有column unique id？？
##########
be/src/olap/delete_handler.cpp:
##########
@@ -71,6 +74,9 @@ Status DeleteHandler::generate_delete_predicate(const
TabletSchema& schema,
for (const TCondition& condition : conditions) {
if (condition.condition_values.size() > 1) {
InPredicatePB* in_pred = del_pred->add_in_predicates();
+ if (condition.__isset.column_unique_id) {
+ in_pred->set_column_unique_id(condition.column_unique_id);
Review Comment:
这里的condition 的 unique id 不一定被设置了吧？ 如果没设置，此时是不是即使是v2 ，那么也没有column unique id？？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
